DM-42127: Add htcondor support for bps report --return-exit-codes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new flag to the report() method of HTCondorService class that controls if the non-zero exit codes should be included in the report.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 15.24% 16.95% +1.71%
==========================================
Files 4 5 +1
Lines 1358 1392 +34
Branches 290 294 +4
==========================================
+ Hits 207 236 +29
- Misses 1149 1153 +4
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
Updated pre-commit config file to use the most recent Black.
MichelleGower
approved these changes
Jan 30, 2024
mxk62
force-pushed
the
tickets/DM-42127
branch
from
db78e53
to
ec94175
Compare
Modified the function responsible for gathering exit codes to omit error codes for jobs that finished successfully (i.e. returned 0 exit code) to align the plugin behavior with the one already implemented in the PanDA plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes