Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42759: Update usage of htcondor to remove deprecation warnings in rubin env 8 #30

Merged
merged 4 commits into from Feb 2, 2024
Merged

DM-42759: Update usage of htcondor to remove deprecation warnings in rubin env 8 #30

merged 4 commits into from Feb 2, 2024

Conversation

mxk62
Copy link
Collaborator

@mxk62 mxk62 commented Feb 2, 2024 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mxk62
Replace Schedd.xquery() with Schedd.query()
3c09c6a 
Schedd.xqery() is being deprecated by the HTCondor team in favor of
Schedd.query().  Both methods can be traced back to at least HTCondor
ver. 8.8 so I just replaced the only occurance of xquery() with query().
@mxk62
Use Schedd.submit() instead of Schedd.transaction()
9c09587 
Similarly to Schedd.xquery(), the Schedd.transation() and Submit.queue()
are being deprecated by the HTCodnor team.  Hence, I rewrote the
fucntion submit the DAG for execution to make it preferred
Schedd.submit().
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b1a50bc) 16.95% compared to head (d128430) 17.01%.
Report is 1 commits behind head on main.

Files Patch % Lines
python/lsst/ctrl/bps/htcondor/lssthtc.py 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   16.95%   17.01%   +0.06%     
==========================================
  Files           5        5              
  Lines        1392     1387       -5     
  Branches      294      292       -2     
==========================================
  Hits          236      236              
+ Misses       1153     1148       -5     
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Copy link
Member

timj commented Feb 2, 2024

Do you need to change the pin in pyproject.toml? Currently it has:

"htcondor >= 8.8",

@mxk62
Copy link
Collaborator Author

mxk62 commented Feb 2, 2024

Theoretically, no. I traced the existence of Schedd.submit() and Schedd.query() back to HTCondor ver. 8.8. So the changes I made should not impact the BPS users having access to HTCondor pools using older versions of HTCondor.

It's just that "back then" (and essentially until 10.0) the official documentation explicitly recommended using Schedd.xquery() over Schedd.query()for retrieving many and/or large job ClassAds to reduce memory requirements. Similarly with Schedd.transaction(), examples of submitting jobs with HTCondor Python API provided in the docs were using this method instead of Schedd.submit().

MichelleGower
MichelleGower approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions on changes file. Looks good to me. Merge approved.

doc/changes/DM-40906.misc.rst Outdated Show resolved Hide resolved
@mxk62 mxk62 merged commit 03e6e06 into main Feb 2, 2024
12 of 13 checks passed
@mxk62 mxk62 deleted the tickets/DM-42759 branch February 2, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleGower MichelleGower MichelleGower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mxk62 @timj @MichelleGower