New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35347: Switch to pyproject.toml #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage 15.53% 15.53%
=======================================
Files 4 4
Lines 1294 1294
Branches 285 285
=======================================
Hits 201 201
+ Misses 1091 1083 -8
- Partials 2 10 +8
Continue to review full report at Codecov.
|
.github/workflows/build.yaml
Outdated
with: | ||
python-version: 3.10 | ||
cache: "pip" | ||
cache-dependency-path: "setup.cfg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pyproject.toml a supported option here? (now that we aren't using setup.cfg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this makes sense when using pyproject.toml and python-build. I would opt to remove cache-dependency-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how clever the caching is. For all I knew it did understand the new pyproject.toml
way of specifying dependencies but if it does not then there's no point keeping it around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can ask it to cache from the requirements.txt instead. https://github.com/actions/setup-python#caching-packages-dependencies
7805f6a
to
5be261d
Compare
Checklist
doc/changes