Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35347: Switch to pyproject.toml #6

Merged
merged 1 commit into from Jul 14, 2022
Merged

DM-35347: Switch to pyproject.toml #6

merged 1 commit into from Jul 14, 2022

Conversation

mwittgen
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mwittgen mwittgen requested a review from timj July 13, 2022 00:18
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #6 (7805f6a) into main (4ca1b9b) will not change coverage.
The diff coverage is n/a.

❗ Current head 7805f6a differs from pull request most recent head 5be261d. Consider uploading reports for the commit 5be261d to get more accurate results

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   15.53%   15.53%           
=======================================
  Files           4        4           
  Lines        1294     1294           
  Branches      285      285           
=======================================
  Hits          201      201           
+ Misses       1091     1083    -8     
- Partials        2       10    +8     
Impacted Files Coverage Δ
python/lsst/ctrl/bps/htcondor/lssthtc.py 18.11% <0.00%> (ø)
python/lsst/ctrl/bps/htcondor/htcondor_service.py 9.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca1b9b...5be261d. Read the comment docs.

with:
python-version: 3.10
cache: "pip"
cache-dependency-path: "setup.cfg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pyproject.toml a supported option here? (now that we aren't using setup.cfg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this makes sense when using pyproject.toml and python-build. I would opt to remove cache-dependency-path

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how clever the caching is. For all I knew it did understand the new pyproject.toml way of specifying dependencies but if it does not then there's no point keeping it around.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you can ask it to cache from the requirements.txt instead. https://github.com/actions/setup-python#caching-packages-dependencies

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@mwittgen mwittgen merged commit f92471e into main Jul 14, 2022
@mwittgen mwittgen deleted the tickets/DM-35347 branch July 14, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants