New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34964: add cancel, restart and ping function in the bps panda plugin #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming @MichelleGower will also take a look from a bps perspective.
I have many comments but I think most of them are easy to deal with.
I do have a concern about the return values from idds APIs being very hard to use. It looks like there are tuples with tuples and the code here would benefit significantly from those APIs returning objects that can be inspected with methods.
Code like this:
if ret[0] == 0 and ret[1][0]
is very hard to follow and would be much easier if ret
was an object that could have methods run on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay now. Thanks for the changes. Some minor comments and I'll leave the rest for @MichelleGower.
Please consider using pre-commit
so that the code is black-compatible before it is committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my tests, report isn't working as expected. Also, the behavior in error cases isn't the same as the expected behavior for all of the new functions. And a heads up that the expected ping method signature will be different than it appears here.
a9c7499
to
be97783
Compare
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 35.28% 32.65% -2.63%
==========================================
Files 9 9
Lines 479 539 +60
Branches 79 91 +12
==========================================
+ Hits 169 176 +7
- Misses 307 360 +53
Partials 3 3
Continue to review full report at Codecov.
|
Checklist
doc/changes