Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36375 fast handle dev/test tasks #28

Merged
merged 1 commit into from Oct 25, 2022
Merged

DM-36375 fast handle dev/test tasks #28

merged 1 commit into from Oct 25, 2022

Conversation

zhaoyuyoung
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 32.29% // Head: 32.29% // No change to project coverage 👍

Coverage data is based on head (dcd51a5) compared to base (2152d6f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   32.29%   32.29%           
=======================================
  Files           9        9           
  Lines         545      545           
  Branches       86       86           
=======================================
  Hits          176      176           
  Misses        366      366           
  Partials        3        3           
Impacted Files Coverage Δ
python/lsst/ctrl/bps/panda/panda_service.py 20.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor question about a comment. I agree with the changes recommended by @wguanicedew:
(1) add "docs/changes" file
(2) Maybe you can also add a default priority=500 in the bps_panda.yaml file.
Merge approved after addressing questions/suggestions (in particular docs/changes file).

@@ -1,6 +1,6 @@
# An example bps submission yaml
# Need to setup USDF before submitting the yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment be tweaked (In particular asking about the "USDF")? Asking because same comment for test_sdf.yaml and test_usdf.yaml, but the source commands are different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the comment to manifest its for SDF cluster.

@zhaoyuyoung zhaoyuyoung merged commit f367ebb into main Oct 25, 2022
@zhaoyuyoung zhaoyuyoung deleted the tickets/DM-36375 branch October 25, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants