Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35296: ctrl_bps_panda report #29

Merged
merged 1 commit into from Dec 2, 2022
Merged

DM-35296: ctrl_bps_panda report #29

merged 1 commit into from Dec 2, 2022

Conversation

zhaoyuyoung
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 32.29% // Head: 29.94% // Decreases project coverage by -2.34% ⚠️

Coverage data is based on head (9ce91f7) compared to base (f367ebb).
Patch coverage: 4.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   32.29%   29.94%   -2.35%     
==========================================
  Files           9        9              
  Lines         545      591      +46     
  Branches       86       99      +13     
==========================================
+ Hits          176      177       +1     
- Misses        366      411      +45     
  Partials        3        3              
Impacted Files Coverage Δ
python/lsst/ctrl/bps/panda/panda_service.py 16.37% <4.16%> (-3.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhaoyuyoung zhaoyuyoung force-pushed the tickets/DM-35296 branch 3 times, most recently from 3146534 to 1d6a9e6 Compare November 10, 2022 20:51
@zhaoyuyoung zhaoyuyoung force-pushed the tickets/DM-35296 branch 3 times, most recently from 0447ef5 to a150d74 Compare November 19, 2022 15:52
@zhaoyuyoung zhaoyuyoung marked this pull request as ready for review November 19, 2022 15:54
@zhaoyuyoung zhaoyuyoung force-pushed the tickets/DM-35296 branch 2 times, most recently from 175300b to 34c177a Compare November 21, 2022 20:22
Copy link
Collaborator

@mxk62 mxk62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add the "news item" to doc/changes briefly describing what did you do in this ticket. (See README.rst there for further instructions.)

python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/panda/panda_service.py Outdated Show resolved Hide resolved
@mxk62 mxk62 changed the title WIP ctrl_bps_panda report DM-35296: ctrl_bps_panda report Dec 1, 2022
@zhaoyuyoung zhaoyuyoung merged commit c44796e into main Dec 2, 2022
@zhaoyuyoung zhaoyuyoung deleted the tickets/DM-35296 branch December 2, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants