Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34915: Convert from bps to idds workflow in prepare. #34

Merged
merged 1 commit into from Jan 26, 2023

Conversation

MichelleGower
Copy link
Contributor

@MichelleGower MichelleGower commented Jan 20, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 29.93% // Head: 29.17% // Decreases project coverage by -0.76% ⚠️

Coverage data is based on head (7f54dda) compared to base (5a932b5).
Patch coverage: 20.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   29.93%   29.17%   -0.76%     
==========================================
  Files           9       10       +1     
  Lines         598      449     -149     
  Branches      100       76      -24     
==========================================
- Hits          179      131      -48     
+ Misses        416      315     -101     
  Partials        3        3              
Impacted Files Coverage Δ
python/lsst/ctrl/bps/panda/cmd_line_embedder.py 30.30% <14.28%> (-1.84%) ⬇️
python/lsst/ctrl/bps/panda/panda_service.py 18.18% <14.28%> (+2.09%) ⬆️
python/lsst/ctrl/bps/panda/utils.py 15.18% <15.18%> (ø)
python/lsst/ctrl/bps/panda/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

os.path.join(file_distribution_uri, folder_name)
)

copy_executor = concurrent.futures.ThreadPoolExecutor(max_workers=10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a cfg variable or an environment to control max_workers here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added default constant: PANDA_DEFAULT_MAX_COPY_WORKERS = 10, and changed code to look for maxCopyWorkers in the submit yaml.

"available": False,
}
)
work.dependency_map.append({"name": pseudo_filename, "submitted": False, "dependencies": deps})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'"submitted": False' can be removed. It's not used by iDDS.

@MichelleGower MichelleGower marked this pull request as ready for review January 26, 2023 16:21
@MichelleGower MichelleGower merged commit 266a22c into main Jan 26, 2023
@MichelleGower MichelleGower deleted the tickets/DM-34915 branch January 26, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants