DM-38142: Update ctrl_bps_panda/config/bps_usdf.yaml to allow for local custom … #40
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 28.66% 28.66%
=======================================
Files 10 10
Lines 457 457
Branches 81 81
=======================================
Hits 131 131
Misses 323 323
Partials 3 3 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zhaoyuyoung
force-pushed
the
tickets/DM-38142
branch
2 times, most recently
from
c5e2dbf
to
ad884ba
Compare
There was a problem hiding this comment.
- Needs doc/changes file.
- Is there documentation somewhere (panda.lsst.io maybe) where custom_lsst_setup needs to be mentioned?
- I think this meets the user's request. However, in this or some other ticket, similar changes should be made to the bps_idf.yaml as this feature is not usdf specific (even though the value of custom_lsst_setup is different). Also, after pulling this out, can runnerCommand now only appear in the central bps_panda.yaml? (maybe another "extra_docker_env" bps setting needs to be introduced and only have a value at IDF?).
config/bps_usdf.yaml
Outdated
| @@ -10,10 +10,13 @@ computeSite: SLAC | |||
| requestMemory: 2048 | |||
| # PanDA does the scheduling based on memory request | |||
|
|
|||
|
|
|||
| custom_lsst_setup: "" | |||
| setupLSSTEnv: > | |||
| source /cvmfs/sw.lsst.eu/linux-x86_64/lsst_distrib/{LSST_VERSION}/loadLSST.bash; | |||
| pwd; ls -al; | |||
There was a problem hiding this comment.
Not sure why the "pwd; ls -al;" is in the middle of setupLSSTEnv. If the runnerCommand needs to be in a certain directory or have certain files there, those two commands would be better in the runnerCommand after setupLSSTEnv to give helpful debugging info in case the user's custom_lsst_setup commands change expected directory behavior.
There was a problem hiding this comment.
Moved to runnerCommand
zhaoyuyoung
force-pushed
the
tickets/DM-38142
branch
from
ad884ba
to
f8afffe
Compare
…setup
Checklist
doc/changes