Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39553: Update BPS PanDA plugin for quantum-backed butler. #52

Merged
merged 3 commits into from Jul 13, 2023

Conversation

MichelleGower
Copy link
Contributor

@MichelleGower MichelleGower commented Jul 11, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 90.47% and project coverage change: +8.48 🎉

Comparison is base (052cf0f) 23.99% compared to head (ada5355) 32.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   23.99%   32.48%   +8.48%     
==========================================
  Files           7        8       +1     
  Lines         446      508      +62     
  Branches       84       90       +6     
==========================================
+ Hits          107      165      +58     
- Misses        336      339       +3     
- Partials        3        4       +1     
Impacted Files Coverage Δ
python/lsst/ctrl/bps/panda/utils.py 12.50% <0.00%> (-0.14%) ⬇️
python/lsst/ctrl/bps/panda/cmd_line_embedder.py 52.08% <87.50%> (+21.78%) ⬆️
tests/test_cmd_line_embedder.py 95.55% <95.55%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichelleGower MichelleGower changed the title Update BPS PanDA plugin for quantum-backed butler. DM-39553: Update BPS PanDA plugin for quantum-backed butler. Jul 11, 2023
@MichelleGower MichelleGower force-pushed the tickets/DM-39553 branch 3 times, most recently from 4bf8109 to 7703dda Compare July 11, 2023 20:48

Returns
-------
processed command line
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Returns sections should look like this:

cmd_line: `str`
    processed command line

python/lsst/ctrl/bps/panda/cmd_line_embedder.py Outdated Show resolved Hide resolved
@MichelleGower MichelleGower merged commit 72cefa8 into main Jul 13, 2023
13 checks passed
@MichelleGower MichelleGower deleted the tickets/DM-39553 branch July 13, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants