Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42090: Fix the typo in the job attribute in ctrl_bps_panda #63

Merged
merged 2 commits into from
Dec 13, 2023
Merged

DM-42090: Fix the typo in the job attribute in ctrl_bps_panda #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69174a0
Fix a typo in the reference of a job attribute
Dec 11, 2023
0509c5e
Describe changes in the news item
Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/DM-42090.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a typo in the reference of a job attribute.
2 changes: 1 addition & 1 deletion python/lsst/ctrl/bps/panda/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@
)

task_rss = gwjob.request_memory if gwjob.request_memory else PANDA_DEFAULT_RSS
task_rss_retry_step = task_rss * gwjob.memory_multiplier if gwjob.memory_mulitplier else 0
task_rss_retry_step = task_rss * gwjob.memory_multiplier if gwjob.memory_multiplier else 0

Check warning on line 253 in python/lsst/ctrl/bps/panda/utils.py

View check run for this annotation

Codecov / codecov/patch

python/lsst/ctrl/bps/panda/utils.py#L253 

Added line #L253 was not covered by tests
task_rss_retry_offset = 0 if task_rss_retry_step else task_rss

# Assume input files are same across task
Expand Down