DM-42528: Fix reporting request status #65
Conversation
|
|
||
| wf_succeed = False | ||
| workflow_status = head["status"]["attributes"]["_name_"] | ||
| if workflow_status in ["Finished", "SubFinished"]: |
There was a problem hiding this comment.
What does subfinished mean in particular to understand why it means succeeded?
There was a problem hiding this comment.
Does this give the correct status for when the final job hasn't shown up yet in PanDA tasks?
There was a problem hiding this comment.
yes. It's the workflow status in iDDS. In the iDDS result, there are two parts about the status: (1) 'status': the workflow/request status, it includes the last task even it's not created. (2) 'transform_status': It's the task status, per task.
In WmsStates, there is no item to distinguish 'Subfinished'. That's why I mapped it to Succeeded.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 36.67% 36.21% -0.47%
==========================================
Files 9 9
Lines 548 555 +7
Branches 95 99 +4
==========================================
Hits 201 201
- Misses 338 345 +7
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
The doc build failure is caused by the documenteer version. Please change the github action to pin the documenteer version to 0.8.2. |
timj
changed the title
After updating documenteer version to 0.8.2, the build doc still failed. Do you have any idea how to fix it? |
|
You need to rebase don't you? It's fixed on main via #66 but not on this branch which is still installing a different documenteer version. |
wguanicedew
force-pushed
the
tickets/DM-42528
branch
from
731ec13
to
c1c7d3c
Compare
|
The build docs work ok. The local test also works ok. I will merge it. |
Checklist
doc/changes