Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm: add support for getting scheduler_options from BPS config #11

Merged
merged 1 commit into from Jan 4, 2023

Conversation

PaulPrice
Copy link
Contributor

@PaulPrice PaulPrice commented Jan 4, 2023

This saves users from having to subclass the Slurm site.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This saves users from having to subclass the Slurm site.
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 70.37% // Head: 70.37% // No change to project coverage 👍

Coverage data is based on head (33da0bd) compared to base (8136386).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files           3        3           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           19       19           
  Misses          6        6           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@PaulPrice PaulPrice merged commit 538deb7 into main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants