DM-38146: Update Princeton site interface from ib0 to op0

[leeskelvin]

Checklist

• ran Jenkins
• added a release note for user-visible changes to doc/changes

[codecov]

Codecov Report

Base: 70.37% // Head: 70.37% // No change to project coverage 👍

Coverage data is based on head (071ee23) compared to base (c3cf636).
Patch has no changes to coverable lines.

❗ Current head 071ee23 differs from pull request most recent head 1bf5330. Consider uploading reports for the commit 1bf5330 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files           3        3           
  Lines          27       27           
  Branches        6        4    -2     
=======================================
  Hits           19       19           
  Misses          6        6           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[timj]

This seems fragile if we have to change it a lot. Have you considered having an environment variable fallback?

[leeskelvin]

My feeling is that this shouldn't change a lot, but I may be off base about that. Do you have an example of env vars in use elsewhere that we might use here as an example?

One possibility I considered is making use of the get_all_addresses function within parsl.addresses, but I'm not sure how to use the information provided there to make the choice on the 'best' address to use.

[MichelleGower]

Or a yaml config value (I think self contains the bps config)?

[leeskelvin]

I've been in touch with Princeton IT regarding whether or not this variable is likely to change again in the future. To quote:

this will not and cannot change. op0 was always the main high speed interface for tiger2 cluster

I think therefore that the fix we're making on this ticket is changing the Princeton site settings to what they should have been originally, and this is not likely to change again in the future. With that in mind, I'm inclined to leave this as-is and not add any user-specified fall-back. I.e., if this does break in the future, it's probably something we want to fail fast and fix in consultation with Princeton IT, rather than be hidden behind any kind of fall back procedure.

[leeskelvin]

On further discussion with a different member of staff within Princeton IT, it appears that this device interface may indeed change back to ib0 or ibN at some future date, likely when the clusters are eventually upgraded. With that in mind, I've modified this ticket to make use of the same back-end within parsl (the psutil function net_if_addrs) to list all possible network interfaces and match only to those starting with either ib* or op*. I hope this will make us robust to any future configuration updates, removing the need to fix this issue if/when it crops up again.

@PaulPrice, do these new changes look okay to you?

[timj]

Add this to your mypy.ini:

[mypy-psutil.*]
ignore_missing_imports = True

[PaulPrice]

Drop the else.

[leeskelvin]

This function may then return nothing, which would cause make_executor inside lsst/ctrl/bps/parsl/sites/slurm.py to fail with a generic error. Is that better than a specific error raised here?

[timj]

I interpreted @PaulPrice as saying write:

if net_interfaces:
    return blah
raise RuntimError("reason")

[leeskelvin]

Ah, literally just the else line, thanks. Yes, that makes sense, cheers.