DM-42421: Remove --slurmd-debug argument from Princeton site #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jan 9, 2024
This argument is being removed as it's causing srun to fail with the error message: srun: error: Use of --slurmd-debug is allowed only for root and SlurmUser(slurm) It is not clear when this argument became problematic, however, it must have occurred within the last month or two. Nevertheless, use of this argument is seemingly not required for successful pipeline execution, so it is being removed on this ticket.
leeskelvin
force-pushed
the
tickets/DM-42421
branch
from
1d0682c
to
eee79e1
Compare
|
Thanks @PaulPrice. Extra commit log message added: |
leeskelvin
force-pushed
the
tickets/DM-42421
branch
from
eee79e1
to
ad2c209
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 47.46% 47.46%
=======================================
Files 11 11
Lines 375 375
Branches 61 61
=======================================
Hits 178 178
Misses 191 191
Partials 6 6 ☔ View full report in Codecov by Sentry. |
This temporary pointer to daf_butler on GitHub main is put in place to resolve an emergent issue in that package causing an issue with pyarrow. In brief, in daf_butler, PyPI depends on pyarrow, but the package doesn't indicate that it depends on pyarrow. This temporary edit in this package should allow for this PR to merge now. Future edits to ctrl_bps_parsl should remove this hotfix once a main fix has been put in place (expected 2024-01-10). EDIT: Temporary pointers to pipe_base and ctrl_mpexec have also been edded on this commit. EDIT2: documenteer also temporarily pinned to v0.8.2.
leeskelvin
force-pushed
the
tickets/DM-42421
branch
from
ad2c209
to
462f160
Compare
Possible context: Years ago, we added this parameter at NERSC while debugging some slurm/srun vs parsl behaviour around job failure (I think). I think it's likely that it then stuck around as being copy-and-paste mostly-harmless in configs ever since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes