Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM:42101: changes for new qos handling #24

Merged
merged 3 commits into from Dec 8, 2023
Merged

DM:42101: changes for new qos handling #24

merged 3 commits into from Dec 8, 2023

Conversation

daues
Copy link
Contributor

@daues daues commented Dec 8, 2023

No description provided.

MichelleGower
MichelleGower approved these changes Dec 8, 2023
View reviewed changes
Copy link

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Merge approved.

python/lsst/ctrl/execute/slurmPlugin.py Outdated
)
else:
self.defaults["RESERVATION"] = ""

if self.opts.qos is not None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since self.opts.qos is a str --> if self.opts.qos:
(https://developer.lsst.io/python/style.html#is-and-is-not-should-be-used-when-comparing-to-none)

@daues daues merged commit 1e8eb4f into main Dec 8, 2023
3 checks passed
@daues daues deleted the tickets/DM-42101 branch December 8, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleGower MichelleGower MichelleGower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daues @MichelleGower