Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27653: output.chain[0] now only returns a str not tuple so change assignement #100

Merged
merged 2 commits into from Nov 19, 2020
Merged

DM-27653: output.chain[0] now only returns a str not tuple so change assignement #100

merged 2 commits into from Nov 19, 2020

Conversation

timj
Copy link
Member

@timj timj commented Nov 18, 2020

No description provided.

@andy-slac
Copy link
Collaborator

Maybe also change type annotation at line 109 to say that chain is a list of strings?

@timj
Copy link
Member Author

timj commented Nov 18, 2020

I'm sure this is where @TallJimbo would let us know that type annotations being used would have told us about this problem up front.

@timj timj requested a review from TallJimbo November 18, 2020 23:41
TallJimbo
TallJimbo approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That thought about type checking did cross my mind 🙂 . Looks good, and thanks for taking care of it!

@timj timj merged commit 4212b72 into master Nov 19, 2020
@timj timj deleted the tickets/DM-27653 branch November 19, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timj @andy-slac @TallJimbo