DM-27835: pipetask run should always print stack trace and exception details #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Dec 7, 2020
tests/test_cmdLineFwk.py
Outdated
| if result.exit_code != 0: | ||
| raise RuntimeError(f"Failure getting default args from 'pipetask run': {result}") | ||
| _, args = Mocker.mock.call_args | ||
| raise RuntimeError("Failure getting default args from 'pipetask run'.") |
There was a problem hiding this comment.
Did you drop "{result}" from message intentionally? It was helpful for me to debug things, without that I could not figure out what was happening in the code.
There was a problem hiding this comment.
I'll clean this up some to be more clear; the message is misleading; it's not calling "pipetask run", it's calling the "fake" run function (defined a few lines before this), which has the same options as the "real" run function.
It's worth keeping result in too, in case the options fail it may be well explained by result. Or, you may just have to pdb (sorry 🙃), but hopefully it all Just Works all the time!
n8pease
force-pushed
the
tickets/DM-27835
branch
from
fc14763
to
b9b1f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.