DM-27153: adapt to daf_butler changes to defaulting of collections and data IDs #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DatasetTypeRestriction hasn't been used here for a while, so those annotations and docs are just wrong. Docs about the inputs attribute being updated to include outputs were wrong, too, and because it isn't being updated, I've made it a tuple instead of a list so there's no doubt about that.
This is necessary because Butler.__init__ no longer has chains argument that creates CHAINED collections, but this makes what's going on here more explicit and avoids some necessary butler operations (no-ops, but the kind that still involve database calls) by making better use of our knowledge of command-line options.
TallJimbo
force-pushed
the
tickets/DM-27153
branch
from
af87c05
to
a0f2fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.