DM-26302: Use new registry method to reset connection pool. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows passing Butler to a subpocess without pickling it when using fork start method.
TallJimbo
approved these changes
Mar 2, 2021
| quantum_pickle = pickle.dumps(self.qnode.quantum) | ||
| taskDef = self.qnode.taskDef | ||
| logConfigState = CliLog.configState | ||
| mp_ctx = multiprocessing.get_context(startMethod) | ||
| self.process = mp_ctx.Process( | ||
| target=_Job._executeJob, | ||
| args=(quantumExecutor, taskDef, quantum_pickle, butler_pickle, logConfigState), | ||
| args=(quantumExecutor, taskDef, quantum_pickle, butler, logConfigState), |
There was a problem hiding this comment.
I was surprised pickling works here, because of the DimensionUniverse pickle implementation that doesn't really save anything. But I see it worked before, and you'r just slightly changing how it works. Is there an explicit workaround for the DimensionUniverse pickling that just isn't in this diff?
There was a problem hiding this comment.
DimensionUniverse is not pickled but it is re-initialized by registry when we re-instantiate butler (or if the existing butler is used with fork). This is why I need to delay Quantum un-pickling until afer butler is unpickled (by multiprocessing if spawn method is used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing Butler to a subpocess without pickling it when using
fork start method.