Tickets/DM-30702 Add metadata to QuantumGraph #127
Conversation
| metadata = {"input": args.input, "output": args.output, "butler_config": args.butler_config, | ||
| "output_run": args.output_run, "extend_run": args.extend_run, | ||
| "skip_existing": args.skip_existing} |
There was a problem hiding this comment.
On JIRA @timj also asked about few other items: time of creation, user name, data query (should be in args.data_query). I am somewhat concerned that butler_config may point to some temporary location which could disappear, should we be storing registry database URL just in case?
There was a problem hiding this comment.
I think the butler URI for the repository itself is probably better than the ButlerConfig (or at least we should definitely include the butler URI regardless even if we think we also need the config itself).
There was a problem hiding this comment.
args.butler_config here is just a command line argument which is a path/URL, not the whole ButlerConfig.
There was a problem hiding this comment.
Okay. That's not a good name for it then.
There was a problem hiding this comment.
Indeed, historically it comes from --butler-config command line option which by default was translated to butler_config attribute name by argparse (which we don't use any more).
There was a problem hiding this comment.
I changed the key in the metadata to say "butler_argument" to better reflect that it was what was passed on the command line, and side step the name butler_config
Record some command line options with the QuantumGraph metadata
natelust
force-pushed
the
tickets/DM-30702
branch
from
02761ba
to
f17ca38
Compare
Checklist
doc/changes