DM-31507 Explicitly run garbage collection #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some objects are not cleaned up until garbage collection is run, which can happen at unpredictable times. Run collection explicitly to make sure memory is freed. This HOPEFULLY will only be third party objects, and none of our own.
andy-slac
approved these changes
Aug 25, 2021
| # sqlalchemy has some objects that can last until a garbage | ||
| # collection cycle is run, which can happen at unpredictable | ||
| # times, run a collection loop here explicitly. | ||
| gc.collect() |
There was a problem hiding this comment.
Running GC frequently can be very expensive, I wonder if we could avoid pessimization by running it conditionally. In my old project when I did something similar I only ran it when virtual mem size increased significantly since last explicit CG. This of course needs some guessing as to what makes a significant increase, in that project threshold was something like 10MB, but it clearly depends on growth pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects are not cleaned up until garbage collection is run,
which can happen at unpredictable times. Run collection explicitly
to make sure memory is freed. This HOPEFULLY will only be third
party objects, and none of our own.
Checklist
doc/changes