DM-33027: miscellaneous fixes from PipelineGraph work #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Jan 6, 2022
TallJimbo
force-pushed
the
tickets/DM-33027
branch
2 times, most recently
from
bc90dfe
to
135a4b9
Compare
TallJimbo
force-pushed
the
tickets/DM-33027
branch
from
135a4b9
to
6230d1e
Compare
TallJimbo
force-pushed
the
tickets/DM-33027
branch
from
6230d1e
to
34a0a07
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 85.34% 85.26% -0.09%
==========================================
Files 47 47
Lines 4259 4248 -11
Branches 735 732 -3
==========================================
- Hits 3635 3622 -13
- Misses 468 471 +3
+ Partials 156 155 -1
☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-33027
branch
from
34a0a07
to
c438aa2
Compare
TallJimbo
changed the title
TallJimbo
force-pushed
the
tickets/DM-33027
branch
from
c438aa2
to
04ff897
Compare
Because this saves and loads an empty pipeline, the fact that the arguments being passed were wrong went completely unnoticed. Now we at least check that saving the pipeline creates a file.
TallJimbo
force-pushed
the
tickets/DM-33027
branch
from
04ff897
to
48613b2
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Jenkinslocal lsstswdoc/changes(in pipe_base)