Continue execution after task failure (DM-33339) #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-33339
branch
from
5e4e6b1
to
b6d5a2b
Compare
MichelleGower
approved these changes
Jan 26, 2022
In a single-process mode the MPGraphExecutor will try to execute remaining tasks after one of the tasks fails (skipping the tasks that depend on outputs of failed tasks) instead of exiting on an exception. This needed some changes in exception handling, instead of passing an original exeption raised by a task, it now raises MPGraphExecutorError, this is consistent with multi-process case. Task timeouts are not handled in single-process case.
andy-slac
force-pushed
the
tickets/DM-33339
branch
from
b6d5a2b
to
3fea3ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a single-process mode the MPGraphExecutor will try to execute remaining
tasks after one of the tasks fails (skipping the tasks that depend on
outputs of failed tasks) instead of exiting on an exception. This needed
some changes in exception handling, instead of passing an original
exeption raised by a task, it now raises MPGraphExecutorError, this is
consistent with multi-process case. Task timeouts are not handled in
single-process case.
Checklist
doc/changes