New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34215: Support dropping into debugger on exception #177
Conversation
ece5223
to
6e468b1
Compare
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 81.37% 81.16% -0.22%
==========================================
Files 41 41
Lines 3297 3308 +11
Branches 550 552 +2
==========================================
+ Hits 2683 2685 +2
- Misses 455 463 +8
- Partials 159 160 +1
Continue to review full report at Codecov.
|
6e468b1
to
ff8185f
Compare
abd1dce
to
06300f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of minor comments.
06300f1
to
521bba6
Compare
When we get an exception, sometimes it's not enough to just see the backtrace, but we also want to get a debugger prompt at the point of the exception. Replaced the --do-raise option (apparently unused, and often associated with getting a debugger with Gen2) with --pdb (well-known and appreciated option from pytest), which causes MPGraphExecutor._executeQuantaInProcess to drop into pdb.
521bba6
to
7ec6ce7
Compare
When we get an exception, sometimes it's not enough to just
see the backtrace, but we also want to get a debugger prompt
at the point of the exception.
Replaced the --do-raise option (apparently unused, and often
associated with getting a debugger with Gen2) with --pdb
(well-known and appreciated option from pytest), which causes
MPGraphExecutor._executeQuantaInProcess to drop into pdb.
Checklist
doc/changes