Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34215: Support dropping into debugger on exception #177

Merged
merged 1 commit into from Mar 29, 2022

Conversation

PaulPrice
Copy link
Contributor

@PaulPrice PaulPrice commented Mar 28, 2022

When we get an exception, sometimes it's not enough to just
see the backtrace, but we also want to get a debugger prompt
at the point of the exception.

Replaced the --do-raise option (apparently unused, and often
associated with getting a debugger with Gen2) with --pdb
(well-known and appreciated option from pytest), which causes
MPGraphExecutor._executeQuantaInProcess to drop into pdb.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #177 (7ec6ce7) into main (8174bdb) will decrease coverage by 0.21%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   81.37%   81.16%   -0.22%     
==========================================
  Files          41       41              
  Lines        3297     3308      +11     
  Branches      550      552       +2     
==========================================
+ Hits         2683     2685       +2     
- Misses        455      463       +8     
- Partials      159      160       +1     
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/cli/opt/optionGroups.py 100.00% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/run.py 55.55% <ø> (ø)
python/lsst/ctrl/mpexec/cmdLineFwk.py 60.63% <ø> (ø)
python/lsst/ctrl/mpexec/mpGraphExecutor.py 86.75% <18.18%> (-2.74%) ⬇️
python/lsst/ctrl/mpexec/cli/opt/options.py 82.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8174bdb...7ec6ce7. Read the comment docs.

@PaulPrice PaulPrice force-pushed the tickets/DM-34215 branch 3 times, most recently from abd1dce to 06300f1 Compare March 28, 2022 22:49
Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor comments.

python/lsst/ctrl/mpexec/cli/opt/options.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/mpGraphExecutor.py Outdated Show resolved Hide resolved
When we get an exception, sometimes it's not enough to just
see the backtrace, but we also want to get a debugger prompt
at the point of the exception.

Replaced the --do-raise option (apparently unused, and often
associated with getting a debugger with Gen2) with --pdb
(well-known and appreciated option from pytest), which causes
MPGraphExecutor._executeQuantaInProcess to drop into pdb.
@PaulPrice PaulPrice merged commit 1114478 into main Mar 29, 2022
@PaulPrice PaulPrice deleted the tickets/DM-34215 branch March 29, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants