DM-34261: respond to click.Path api change #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 81.16% 81.38% +0.21%
==========================================
Files 41 41
Lines 3308 3298 -10
Branches 552 550 -2
==========================================
- Hits 2685 2684 -1
+ Misses 463 454 -9
Partials 160 160
Continue to review full report at Codecov.
|
There is a split_commas function in daf_butler that can be used. It can be extended to do type conversion (as this one did, to int), or we could write a helper to convert a list of Any items to a list of int items that could be chained with split_commas.
n8pease
force-pushed
the
tickets/DM-34261
branch
from
2abbd92
to
0bd8a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes