Issue a warning when generated QuantumGraph is empty (DM-19372) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleGower
approved these changes
Apr 19, 2019
| # count quanta in graph and give a warning if it's empty | ||
| nQuanta = sum(1 for q in qgraph.quanta()) | ||
| if nQuanta == 0: | ||
| warnings.warn("QuantumGraph is empty", stacklevel=2) |
There was a problem hiding this comment.
Works great. Does the output of warnings.warn also go through the logging module?
There was a problem hiding this comment.
It can be (as you have found already) redirected to logging with logging.captureWarnings. We probably want to add this to pipetask as default settings, I think it's trivial change and can be done on this ticket too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.