DM-35153: Fix collection order in SimplePipelineExecutor #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 47 47
Lines 3755 3755
Branches 676 676
=======================================
Hits 3093 3093
Misses 483 483
Partials 179 179
Continue to review full report at Codecov.
|
natelust
approved these changes
Jun 9, 2022
| @@ -106,7 +106,7 @@ def prep_butler( | |||
| butler.registry.registerCollection(output_run, CollectionType.RUN) | |||
| butler.registry.registerCollection(output, CollectionType.CHAINED) | |||
| collections = list(inputs) | |||
| collections.append(output_run) | |||
| collections.insert(0, output_run) | |||
There was a problem hiding this comment.
Its slightly cart before the horse to create something and then later insert something at the beginning, possibly not something someone would notice at first. what would you think of changing both lines to
Suggested change
| collections.insert(0, output_run) | |
| collections = [output_run] | |
| collections.extend(inputs) |
Its up to you though, I will mark this as reviewed.
There was a problem hiding this comment.
This is very reasonable. I was trying too much to minimize changes.
cmsaunders
force-pushed
the
tickets/DM-35153
branch
from
2f9019c
to
a9315e9
Compare
cmsaunders
force-pushed
the
tickets/DM-35153
branch
from
a9315e9
to
b0cd0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output collection should be first in the list of collections, not last.
Checklist
doc/changes