Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35047: Add upload to pypi #190

Merged
merged 2 commits into from Jun 10, 2022
Merged

DM-35047: Add upload to pypi #190

merged 2 commits into from Jun 10, 2022

Conversation

mwittgen
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mwittgen mwittgen requested a review from timj June 10, 2022 22:36
setup.cfg Outdated
@@ -1,18 +1,25 @@
[metadata]
name = ctrl_mpexec
name = lsst-ctrl-mpexec
description = Pipeline execution infrastructure for the Rubin Science Pipelines
author = Rubin Observatory Data Management
url = https://github.com/lsst/resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong URL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should use solely python 3.10?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are replying to the other comment...

setup.cfg Outdated
classifiers =
Intended Audience :: Science/Research
License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)
License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)
Operating System :: OS Independent
Programming Language :: Python :: 3
Programming Language :: Python :: 3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this now failed on python 3.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should use 3.10?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were testing the different python versions before declaring them to work. I think ctrl_mpexec has a problem with 3.8 type annotations (found by ctrl_bps). Maybe declare 3.10 then but in a follow up ticket we should enable 3.8, 9, 10 matrix and allow us to properly state which versions we support (we are not actively preventing 3.8 from working but if it stops working we do not care).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #190 (ddaa758) into main (5ad6d16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files          47       47           
  Lines        3755     3755           
  Branches      676      676           
=======================================
  Hits         3093     3093           
  Misses        483      483           
  Partials      179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad6d16...ddaa758. Read the comment docs.

@mwittgen mwittgen changed the title Add upload to pypi DM-35047: Add upload to pypi Jun 10, 2022
@mwittgen mwittgen merged commit 43701df into main Jun 10, 2022
@mwittgen mwittgen deleted the tickets/DM-35047 branch June 10, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants