-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35917: Migrate config setting docs from pipe_base and update code to match expectations #199
Commits on Aug 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 97f561f - Browse repository at this point
Copy the full SHA 97f561fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbed7f7 - Browse repository at this point
Copy the full SHA cbed7f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44f6dee - Browse repository at this point
Copy the full SHA 44f6deeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1fcb9e - Browse repository at this point
Copy the full SHA e1fcb9eView commit details -
Reorganize how the --show option is handled
1. Keep track of which options have been used. 2. No longer run the pipeline show options multiple times for pipetask qgraph. 3. No longer warn about options not being used when they are about to be used. 4. If --show is used, no longer continue on unless there are remaining --show options to process. The latter means that using `pipetask qgraph` with only pipeline show options exits without building the graph, and any use of --show leads to `pipetask run` not running anything.
Configuration menu - View commit details
-
Copy full SHA for ced05c2 - Browse repository at this point
Copy the full SHA ced05c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba9a46 - Browse repository at this point
Copy the full SHA 0ba9a46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9083bc5 - Browse repository at this point
Copy the full SHA 9083bc5View commit details -
Change --config to use split_commas utility
This matches what the click option callback is doing itself and so ensures consitency in option handling.
Configuration menu - View commit details
-
Copy full SHA for 1f28f0b - Browse repository at this point
Copy the full SHA 1f28f0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c86b6 - Browse repository at this point
Copy the full SHA 03c86b6View commit details -
Migrate configuring a task gen2 docs over to gen3 pipetask docs
Also added some additions.
Configuration menu - View commit details
-
Copy full SHA for 16ade77 - Browse repository at this point
Copy the full SHA 16ade77View commit details -
Replace sys.exit with an exception
This is easier to test and it is odd having a class be able to exit.
Configuration menu - View commit details
-
Copy full SHA for 97b27a4 - Browse repository at this point
Copy the full SHA 97b27a4View commit details -
Allow ShowInfo to write to a specified stream
This makes it easier to test the output.
Configuration menu - View commit details
-
Copy full SHA for cf2e0ed - Browse repository at this point
Copy the full SHA cf2e0edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d717ed - Browse repository at this point
Copy the full SHA 7d717edView commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8d86893 - Browse repository at this point
Copy the full SHA 8d86893View commit details
Commits on Aug 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6eac349 - Browse repository at this point
Copy the full SHA 6eac349View commit details -
Disallow comma splitting for --config option
There is a non-zero chance that people might want to specify a command-line config option that includes a comma and it's safer to require people to use multiple --config options.
Configuration menu - View commit details
-
Copy full SHA for f886877 - Browse repository at this point
Copy the full SHA f886877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6526d - Browse repository at this point
Copy the full SHA 0a6526dView commit details -
Now print a message if --show is used with pipetask run or qgraph
This makes it clear why the command finished without doing anything.
Configuration menu - View commit details
-
Copy full SHA for 10d3583 - Browse repository at this point
Copy the full SHA 10d3583View commit details