Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35917: Migrate config setting docs from pipe_base and update code to match expectations #199

Merged
merged 18 commits into from
Aug 26, 2022

Commits on Aug 23, 2022

  1. No longer set MYPYPATH

    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    97f561f View commit details
    Browse the repository at this point in the history
  2. Fix rst error in Returns section

    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    cbed7f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44f6dee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e1fcb9e View commit details
    Browse the repository at this point in the history
  5. Reorganize how the --show option is handled

    1. Keep track of which options have been used.
    2. No longer run the pipeline show options multiple times
       for pipetask qgraph.
    3. No longer warn about options not being used when they
       are about to be used.
    4. If --show is used, no longer continue on unless there are
       remaining --show options to process.
    
    The latter means that using `pipetask qgraph` with only pipeline
    show options exits without building the graph, and any use of
    --show leads to `pipetask run` not running anything.
    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    ced05c2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ba9a46 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9083bc5 View commit details
    Browse the repository at this point in the history
  8. Change --config to use split_commas utility

    This matches what the click option callback is doing itself
    and so ensures consitency in option handling.
    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    1f28f0b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    03c86b6 View commit details
    Browse the repository at this point in the history
  10. Migrate configuring a task gen2 docs over to gen3 pipetask docs

    Also added some additions.
    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    16ade77 View commit details
    Browse the repository at this point in the history
  11. Replace sys.exit with an exception

    This is easier to test and it is odd having a class be able to exit.
    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    97b27a4 View commit details
    Browse the repository at this point in the history
  12. Allow ShowInfo to write to a specified stream

    This makes it easier to test the output.
    timj committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    cf2e0ed View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7d717ed View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    8d86893 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    6eac349 View commit details
    Browse the repository at this point in the history
  2. Disallow comma splitting for --config option

    There is a non-zero chance that people might want to specify
    a command-line config option that includes a comma and it's
    safer to require people to use multiple --config options.
    timj committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f886877 View commit details
    Browse the repository at this point in the history
  3. Add news fragment

    timj committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    0a6526d View commit details
    Browse the repository at this point in the history
  4. Now print a message if --show is used with pipetask run or qgraph

    This makes it clear why the command finished without doing anything.
    timj committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    10d3583 View commit details
    Browse the repository at this point in the history