DM-35971: Pytest requires flake<5 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 82.46% 82.42% -0.05%
==========================================
Files 47 47
Lines 3753 3755 +2
Branches 675 676 +1
==========================================
Hits 3095 3095
- Misses 480 481 +1
- Partials 178 179 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mwittgen
force-pushed
the
tickets/DM-35971
branch
2 times, most recently
from
bcd760b
to
47e9ab6
Compare
fix mypy
mwittgen
force-pushed
the
tickets/DM-35971
branch
from
47e9ab6
to
17b103c
Compare
timj
reviewed
Aug 22, 2022
| @@ -68,8 +68,10 @@ def mockDatasetTypeName(cls, datasetTypeName: str) -> str: | |||
| """Make mock dataset type name from actual dataset type name.""" | |||
| return "_mock_" + datasetTypeName | |||
|
|
|||
| def _get(self, ref: Union[DeferredDatasetRef, DatasetRef]) -> Any: | |||
| def _get(self, ref: Optional[Union[DeferredDatasetRef, DatasetRef]]) -> Any: | |||
There was a problem hiding this comment.
Yes, I had that fix and the other fix on this ticket on #199
There was a problem hiding this comment.
Ah OK, then I take this package out of the ticket.
|
This will be fixed in #199 |
|
Sorry. I didn't mean to imply to close this becasue my PR is not going to merge for a few days and I think we need this PR merged before the weekly goes out. |
timj
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes