Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-36313: Adapt to daf_butler dataset type / collection API changes #205

Merged
merged 1 commit into from Oct 3, 2022
Merged

DM-36313: Adapt to daf_butler dataset type / collection API changes #205

merged 1 commit into from Oct 3, 2022

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Sep 28, 2022 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

andy-slac
andy-slac approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see new release notes in doc/changes, even though PR checklist says there is one (same for pipe_base).

@TallJimbo
Copy link
Member Author

The changelog entry is only over on the daf_butler branch; I forgot to mention that there's a commit for that now, too. And I deleted the checkbox over there when I started that PR as a draft, so I just figured I'd check off these ones.

@TallJimbo TallJimbo merged commit 5035d90 into main Oct 3, 2022
@TallJimbo TallJimbo deleted the tickets/DM-36313 branch October 3, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-slac andy-slac andy-slac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TallJimbo @andy-slac