DM-36831: Disable implicit threading in pipetask by default. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-36831
branch
from
dafa07b
to
d19799e
Compare
timj
reviewed
Nov 2, 2022
doc/changes/DM-36831.feature.md
Outdated
| @@ -0,0 +1 @@ | |||
| Disable implicit threading (e.g. in OpenBLAS) by default in `pipetask run`, with a new `--enable-implicit-threading` option to restore it. | |||
There was a problem hiding this comment.
How about:
Always disable implicit threading (e.g. ...) by default in
pipetask runeven when not using-j.
?
TallJimbo
force-pushed
the
tickets/DM-36831
branch
from
d19799e
to
2c026da
Compare
timj
approved these changes
Nov 2, 2022
Codecov ReportBase: 83.44% // Head: 83.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 83.44% 83.43% -0.01%
==========================================
Files 48 48
Lines 3883 3888 +5
Branches 591 592 +1
==========================================
+ Hits 3240 3244 +4
Misses 473 473
- Partials 170 171 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The new --enable-implicit-threading option to "pipetask run" can be used to turn it back on.
TallJimbo
force-pushed
the
tickets/DM-36831
branch
from
2c026da
to
8d8c832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new --enable-implicit-threading option to "pipetask run" can be used to turn it back on.
Checklist
doc/changes