DM-38601: Fix checkExistingOutputs method to clobber complete outputs #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Apr 6, 2023
| @@ -423,7 +423,7 @@ def makeWriteButler(cls, args: SimpleNamespace, taskDefs: Optional[Iterable[Task | |||
| # collection from its chain collection first. | |||
| with butler.transaction(): | |||
| butler.registry.setCollectionChain(self.output.name, chainDefinition, flatten=True) | |||
| butler.pruneCollection(replaced, purge=True, unstore=True) | |||
| butler.removeRuns([replaced], unstore=True) | |||
There was a problem hiding this comment.
I'm confused. Didn't I already do that in d712735 ?
There was a problem hiding this comment.
Hmm, did I forgot to pull it?
There was a problem hiding this comment.
My fault, indeed, was branching off of old "main".
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 82.41% 82.90% +0.49%
==========================================
Files 46 46
Lines 4037 4113 +76
Branches 769 770 +1
==========================================
+ Hits 3327 3410 +83
+ Misses 526 521 -5
+ Partials 184 182 -2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The logic in the method has been improved to handle the case when clobberOutputs was specified without skipExistingIn. It now correctly removes complete quantum outputs. Added test cases for this behavior.
andy-slac
force-pushed
the
tickets/DM-38601
branch
from
e649335
to
bbf6fae
Compare
timj
approved these changes
Apr 10, 2023
andy-slac
force-pushed
the
tickets/DM-38601
branch
from
bbf6fae
to
6aa519c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in the method has been improved to handle the case when
clobberOutputs was specified without skipExistingIn. It now correctly
removes complete quantum outputs. Added test cases for this behavior.
Checklist
doc/changes