Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39434: Move QBB factory to a separate class #241

Merged
merged 2 commits into from May 31, 2023
Merged

Conversation

andy-slac
Copy link
Collaborator

It was a nested method before and that interfered with pickle in multiprocessing on MacOS. Moved that to a separate callable class.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

It was a nested method before and that interfered with pickle in
multiprocessing on MacOS. Moved that to a separate callable class.
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 44.44% and project coverage change: +1.04 🎉

Comparison is base (572e431) 84.84% compared to head (8b1e934) 85.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   84.84%   85.88%   +1.04%     
==========================================
  Files          50       50              
  Lines        4552     4500      -52     
  Branches      814      793      -21     
==========================================
+ Hits         3862     3865       +3     
+ Misses        502      468      -34     
+ Partials      188      167      -21     
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/cmdLineFwk.py 62.74% <44.44%> (+0.77%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to pickle something in ctrl_mpexec to trigger this code?

python/lsst/ctrl/mpexec/cmdLineFwk.py Show resolved Hide resolved
@andy-slac
Copy link
Collaborator Author

Is it possible to pickle something in ctrl_mpexec to trigger this code?

I can't think of anything right now, but pipelines_check will test it now.

@andy-slac andy-slac merged commit 019fd78 into main May 31, 2023
10 of 11 checks passed
@andy-slac andy-slac deleted the tickets/DM-39434 branch May 31, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants