Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39605: Use butler.dimensions rather than butler.registry.dimensions #244

Merged
merged 8 commits into from Jun 10, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jun 9, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.26 ⚠️

Comparison is base (fcff66f) 85.70% compared to head (c97bf03) 85.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   85.70%   85.45%   -0.26%     
==========================================
  Files          47       47              
  Lines        4198     4200       +2     
  Branches      722      722              
==========================================
- Hits         3598     3589       -9     
- Misses        448      458      +10     
- Partials      152      153       +1     
Impacted Files Coverage Δ
python/lsst/ctrl/mpexec/cli/cmd/commands.py 66.22% <ø> (ø)
python/lsst/ctrl/mpexec/cli/opt/optionGroups.py 100.00% <ø> (ø)
python/lsst/ctrl/mpexec/cli/pipetask.py 93.33% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/build.py 81.81% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/cleanup.py 96.87% <ø> (ø)
...n/lsst/ctrl/mpexec/cli/script/pre_exec_init_qbb.py 42.85% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/qgraph.py 42.85% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/run.py 45.45% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/run_qbb.py 42.85% <ø> (ø)
python/lsst/ctrl/mpexec/cli/utils.py 90.00% <ø> (ø)
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj requested a review from andy-slac June 10, 2023 01:46
@timj
Copy link
Member Author

timj commented Jun 10, 2023

@andy-slac here's another large PR for docstrings and type annotations. Sorry. Can wait until next week.

Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, few minor comments.

python/lsst/ctrl/mpexec/cli/script/qgraph.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/mpGraphExecutor.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/mpGraphExecutor.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/simple_pipeline_executor.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/simple_pipeline_executor.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/singleQuantumExecutor.py Outdated Show resolved Hide resolved
@timj timj merged commit 3e79529 into main Jun 10, 2023
10 of 11 checks passed
@timj timj deleted the tickets/DM-39605 branch June 10, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants