New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-39605: Use butler.dimensions rather than butler.registry.dimensions #244
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 85.70% 85.45% -0.26%
==========================================
Files 47 47
Lines 4198 4200 +2
Branches 722 722
==========================================
- Hits 3598 3589 -9
- Misses 448 458 +10
- Partials 152 153 +1
☔ View full report in Codecov by Sentry. |
@andy-slac here's another large PR for docstrings and type annotations. Sorry. Can wait until next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, few minor comments.
Checklist
doc/changes