DM-39661: Add support for ExecutionResources #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 85.51% 85.32% -0.20%
==========================================
Files 47 47
Lines 4224 4251 +27
Branches 726 732 +6
==========================================
+ Hits 3612 3627 +15
- Misses 458 469 +11
- Partials 154 155 +1
☔ View full report in Codecov by Sentry. |
timj
changed the title
timj
force-pushed
the
tickets/DM-39661
branch
2 times, most recently
from
effe28f
to
4b2eee5
Compare
timj
force-pushed
the
tickets/DM-39661
branch
3 times, most recently
from
7b1da04
to
f0b7212
Compare
Passed to the ButlerQuantumContext constructor at execution time.
This simplifies the code here. Retain the tests even though they are now mostly testing the ExecutionResources constructor is compatible with the command-line and duplicating tests in pipe_base. This change means that a failure to parse the memory unit is no longer ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires lsst/pipe_base#344
Add
--cores-per-quantumand--memory-per-quantumoptions.Checklist
doc/changes