DM-39672: make it possible to force failures in mock pipelines on the command-line #247
Conversation
TallJimbo
force-pushed
the
tickets/DM-39672
branch
2 times, most recently
from
ca13aff
to
1ed856e
Compare
| when mocking execution. This is a colon-separated 3-tuple, | ||
| where the first entry the task label, the second the | ||
| fully-qualified exception type (empty for ValueError, and the | ||
| third a string (usually quoted) of the form passed to --where, |
There was a problem hiding this comment.
"usually quoted" may be a bit confusing. I guess quoting is needed for shell only, not for the Python code that parses it?
There was a problem hiding this comment.
Yes, just for the shell. Reworded to that effect.
| return result | ||
| for entry in value: | ||
| try: | ||
| task_label, error_type_name, where = entry.split(":") |
There was a problem hiding this comment.
One more comment - what if where part also contains a colon (e.g. for slicing)?
There was a problem hiding this comment.
Good catch. I've updated this to
task_label, error_type_name, *where_terms = entry.split(":")
where = ":".join(where_terms)
to guard against that.
There was a problem hiding this comment.
entry.split(":", 2) is probably faster 🙂
There was a problem hiding this comment.
Neat, I didn't know about that argument.
TallJimbo
force-pushed
the
tickets/DM-39672
branch
from
1ed856e
to
3866086
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 85.69% 85.53% -0.16%
==========================================
Files 47 47
Lines 4215 4231 +16
Branches 724 726 +2
==========================================
+ Hits 3612 3619 +7
- Misses 451 458 +7
- Partials 152 154 +2
☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-39672
branch
from
3866086
to
8a44210
Compare
Checklist
doc/changes