DM-39857: Remove --flake8 option and add ruff config #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 85.57% 85.55% -0.03%
==========================================
Files 47 47
Lines 4251 4244 -7
Branches 732 732
==========================================
- Hits 3638 3631 -7
Misses 459 459
Partials 154 154
☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
Jul 3, 2023
Comment on lines
313
to
323
| `config`, `config=[Task::]<PATTERN>` or | ||
| `config=[Task::]<PATTERN>:NOIGNORECASE` to dump configuration | ||
| ``config``, ``config=[Task::]<PATTERN>`` or | ||
| ``config=[Task::]<PATTERN>:NOIGNORECASE`` to dump configuration | ||
| fields possibly matching given pattern and/or task label; | ||
| `history=<FIELD>` to dump configuration history for a field, field | ||
| name is specified as [Task::]<PATTERN>; `dump-config`, | ||
| `dump-config=Task` to dump complete configuration for a task given | ||
| its label or all tasks; `pipeline` to show pipeline composition; | ||
| `graph` to show information about quanta; `workflow` to show | ||
| information about quanta and their dependency; `tasks` to show | ||
| task composition; `uri` to show predicted dataset URIs of | ||
| quanta""" | ||
| ``history=<FIELD>`` to dump configuration history for a field, | ||
| field name is specified as ``[Task::]<PATTERN>;`` ``dump-config``, | ||
| ``dump-config=Task`` to dump complete configuration for a task | ||
| given its label or all tasks; ``pipeline`` to show pipeline | ||
| composition; ``graph`` to show information about quanta; | ||
| ``workflow`` to show information about quanta and their | ||
| dependency; ``tasks`` to show task composition; ``uri`` to show | ||
| predicted dataset URIs of quanta""" |
There was a problem hiding this comment.
Maybe de-indent the whole thing?
There was a problem hiding this comment.
Yes, I was trying to work out why it was all like this and failing 😄
There was a problem hiding this comment.
I think that it was initially indented to an opening ( but then black wrapped the initial line but did not de-indent other lines.
This allows butler and pipe_base to be referenced.
Co-authored-by: Andy Salnikov <salnikov@slac.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes