New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-39779: text-based graph visualization of pipelines #256
Conversation
1c12223
to
1f5d16a
Compare
`Config`, it is the object used to configure a Butler. | ||
Only used to resolve pipeline graphs for --show pipeline-graph and | ||
--show task-graph. | ||
**kwargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current version still has the type as dict
[
str,
str]
, but the change does not. Is there a reason for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that the right type for **kwargs
is the value type only, since it's always a dict, and the keys are always strings. And it wasn't actually true before that the values were all strings, and I think that's most appropriately handled in this case by leaving out the type from the docs entirely.
3e93970
to
050a579
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 87.20% 87.10% -0.10%
==========================================
Files 47 47
Lines 4337 4367 +30
Branches 750 755 +5
==========================================
+ Hits 3782 3804 +22
- Misses 400 405 +5
- Partials 155 158 +3
☔ View full report in Codecov by Sentry. |
0e11600
to
ffb609e
Compare
1d9beb2
to
01b3285
Compare
Checklist
doc/changes