Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39779: text-based graph visualization of pipelines #256

Merged
merged 6 commits into from Sep 13, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Aug 4, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

`Config`, it is the object used to configure a Butler.
Only used to resolve pipeline graphs for --show pipeline-graph and
--show task-graph.
**kwargs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version still has the type as dict [str, str], but the change does not. Is there a reason for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the right type for **kwargs is the value type only, since it's always a dict, and the keys are always strings. And it wasn't actually true before that the values were all strings, and I think that's most appropriately handled in this case by leaving out the type from the docs entirely.

@TallJimbo TallJimbo force-pushed the tickets/DM-39779 branch 2 times, most recently from 3e93970 to 050a579 Compare August 25, 2023 02:31
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 78.46% and project coverage change: -0.10% ⚠️

Comparison is base (5122111) 87.20% compared to head (1d9beb2) 87.10%.

❗ Current head 1d9beb2 differs from pull request most recent head 01b3285. Consider uploading reports for the commit 01b3285 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   87.20%   87.10%   -0.10%     
==========================================
  Files          47       47              
  Lines        4337     4367      +30     
  Branches      750      755       +5     
==========================================
+ Hits         3782     3804      +22     
- Misses        400      405       +5     
- Partials      155      158       +3     
Files Changed Coverage Δ
python/lsst/ctrl/mpexec/cli/cmd/commands.py 65.80% <0.00%> (-0.87%) ⬇️
python/lsst/ctrl/mpexec/cli/opt/optionGroups.py 100.00% <ø> (ø)
python/lsst/ctrl/mpexec/cli/opt/options.py 87.50% <ø> (ø)
python/lsst/ctrl/mpexec/cli/script/build.py 73.33% <60.00%> (-8.49%) ⬇️
python/lsst/ctrl/mpexec/showInfo.py 74.24% <73.68%> (-0.49%) ⬇️
tests/test_cmdLineFwk.py 98.54% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TallJimbo TallJimbo force-pushed the tickets/DM-39779 branch 2 times, most recently from 0e11600 to ffb609e Compare September 9, 2023 13:12
@TallJimbo TallJimbo merged commit 67eca24 into main Sep 13, 2023
12 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-39779 branch September 13, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants