Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40390: Remove TYPE_CHECKING block to fix DatastoreRecordData import #259

Merged
merged 2 commits into from Aug 15, 2023

Conversation

timj
Copy link
Member

@timj timj commented Aug 15, 2023

There was a code path that was using the class but which failed because it was only imported during type checking.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

There was a code path that was using the class but which
failed because it was only imported during type checking.
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +1.50% 🎉

Comparison is base (9254431) 85.50% compared to head (f5de634) 87.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   85.50%   87.00%   +1.50%     
==========================================
  Files          47       47              
  Lines        4269     4301      +32     
  Branches      601      745     +144     
==========================================
+ Hits         3650     3742      +92     
+ Misses        462      404      -58     
+ Partials      157      155       -2     
Files Changed Coverage Δ
python/lsst/ctrl/mpexec/cmdLineFwk.py 71.84% <ø> (+8.74%) ⬆️
tests/test_cmdLineFwk.py 98.06% <94.11%> (-0.29%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The test has an intentional failure caused by updateRun
being broken. The test should be fixed on DM-40392.
@timj timj requested a review from TallJimbo August 15, 2023 19:17
@timj timj merged commit 8a7d0b7 into main Aug 15, 2023
14 checks passed
@timj timj deleted the tickets/DM-40390 branch August 15, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants