Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40392: Update unit test after fixing QuantumGraph.updateRun #261

Merged
merged 1 commit into from Aug 19, 2023

Conversation

andy-slac
Copy link
Collaborator

@andy-slac andy-slac commented Aug 17, 2023

Depends on lsst/pipe_base#369 and lsst/daf_butler#882

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (0ca651f) 86.97% compared to head (4b0fd74) 87.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   86.97%   87.02%   +0.04%     
==========================================
  Files          47       47              
  Lines        4301     4299       -2     
  Branches      745      744       -1     
==========================================
  Hits         3741     3741              
+ Misses        404      402       -2     
  Partials      156      156              
Files Changed Coverage Δ
tests/test_cmdLineFwk.py 98.44% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andy-slac
Copy link
Collaborator Author

@timj, I can't understand why do-not-merge-checker is not Required for this package while it is Required in pipe_base and daf_butler. do_not_merge.yaml look identical, is there other configuration somewhere which makes it required?

@timj
Copy link
Member

timj commented Aug 18, 2023

I fixed it. There is a setting for branch protections. Each new action has to be explicitly listed as required.

n2 = transfer_from_graph(temp_graph.name, self.root, True, False, False)

# For reasons that have to be investigated the number of
# outputs the second time around is only 21.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the test passes for you I think this means that the 21 I was getting was caused by the bad graph problems and you can remove this comment. We can likely remove the first test and only test that n1 == n2.

@andy-slac andy-slac merged commit 3ef28a6 into main Aug 19, 2023
14 checks passed
@andy-slac andy-slac deleted the tickets/DM-40392 branch August 19, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants