Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41116: Few updates fiollowing Butler interface change #268

Merged
merged 1 commit into from Oct 18, 2023

Conversation

andy-slac
Copy link
Collaborator

@andy-slac andy-slac commented Oct 16, 2023

Butler is now an abstract class, and preferred way to instanciate butlers
is Butler.from_config. Execution butler requires a DirectButler instance,
updated the code to reflect that (somewhat hackish, but execution butler is
going to disappear any minute now or next year).

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Butler is now an abstract class, and preferred way to instanciate butlers
is `Butler.from_config`. Execution butler requires a `DirectButler` instance,
updated the code to reflect that (somewhat hackish, but execution butler is
going to disappear any minute now or next year).
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (cb87889) 87.11% compared to head (9c6d022) 87.07%.

❗ Current head 9c6d022 differs from pull request most recent head 6f72300. Consider uploading reports for the commit 6f72300 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   87.11%   87.07%   -0.04%     
==========================================
  Files          47       47              
  Lines        4369     4372       +3     
  Branches      755      755              
==========================================
+ Hits         3806     3807       +1     
- Misses        405      407       +2     
  Partials      158      158              
Files Coverage Δ
python/lsst/ctrl/mpexec/cli/script/cleanup.py 96.87% <100.00%> (ø)
python/lsst/ctrl/mpexec/cli/script/purge.py 93.00% <100.00%> (ø)
...thon/lsst/ctrl/mpexec/separablePipelineExecutor.py 94.23% <100.00%> (ø)
...ython/lsst/ctrl/mpexec/simple_pipeline_executor.py 91.22% <100.00%> (ø)
tests/test_cliCmdCleanup.py 100.00% <100.00%> (ø)
tests/test_separablePipelineExecutor.py 100.00% <100.00%> (ø)
python/lsst/ctrl/mpexec/cli/script/build.py 73.33% <0.00%> (ø)
python/lsst/ctrl/mpexec/cmdLineFwk.py 73.19% <42.85%> (-0.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andy-slac andy-slac merged commit 17a9813 into main Oct 18, 2023
12 of 14 checks passed
@andy-slac andy-slac deleted the tickets/DM-41116 branch October 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants