DM-41131: Add pipetask report on output of a quantum graph #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigerx
changed the title
|
Looks like you need to run |
arunkannawadi
approved these changes
Oct 27, 2023
eigerx
force-pushed
the
tickets/DM-41131
branch
from
383d32e
to
72ed035
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 87.07% 87.21% +0.13%
==========================================
Files 47 49 +2
Lines 4373 4419 +46
Branches 755 762 +7
==========================================
+ Hits 3808 3854 +46
Misses 407 407
Partials 158 158
☔ View full report in Codecov by Sentry. |
eigerx
force-pushed
the
tickets/DM-41131
branch
2 times, most recently
from
de611a7
to
11f1055
Compare
eigerx
force-pushed
the
tickets/DM-41131
branch
from
11f1055
to
7cfdde6
Compare
tests/test_cliCmdReport.py
Outdated
| @@ -71,7 +71,7 @@ def test_report(self): | |||
|
|
|||
| result = self.runner.invoke( | |||
| pipetask_cli, | |||
| ["report", graph_uri, "-b", self.root, test_filename, "--no-logs"], | |||
| ["repo", self.root, "report", graph_uri, test_filename, "--no-logs"], | |||
There was a problem hiding this comment.
You seem to have swapped the arguments here? It should be
["report", self.root, graph_uri, test_filename, "--no-logs"]
There was a problem hiding this comment.
Thank you thank you thank you!
eigerx
force-pushed
the
tickets/DM-41131
branch
from
4947f88
to
09703a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes