Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42118: Allow run-qbb to have implicit threading disabled #278

Merged
merged 5 commits into from Dec 11, 2023

Conversation

timj
Copy link
Member

@timj timj commented Dec 11, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e072a71) 87.05% compared to head (7fdcd28) 86.96%.

Files Patch % Lines
python/lsst/ctrl/mpexec/cli/script/run.py 33.33% 2 Missing ⚠️
python/lsst/ctrl/mpexec/cli/script/run_qbb.py 33.33% 2 Missing ⚠️
python/lsst/ctrl/mpexec/cmdLineFwk.py 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   87.05%   86.96%   -0.09%     
==========================================
  Files          49       49              
  Lines        4433     4441       +8     
  Branches      766      769       +3     
==========================================
+ Hits         3859     3862       +3     
- Misses        421      425       +4     
- Partials      153      154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! It's belt-and-suspenders-and-braces.

@timj timj merged commit 87b66fa into main Dec 11, 2023
12 of 14 checks passed
@timj timj deleted the tickets/DM-42118 branch December 11, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants