DM-42302: drop support for Pydantic v1 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version claims to be compatible with Pydantic v2 and it works for daf_butler, though there are reasons to doubt it's fully compatible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 87.16% 87.27% +0.11%
==========================================
Files 49 49
Lines 4424 4417 -7
Branches 765 762 -3
==========================================
- Hits 3856 3855 -1
+ Misses 415 410 -5
+ Partials 153 152 -1 ☔ View full report in Codecov by Sentry. |
timj
approved these changes
Jan 3, 2024
TallJimbo
force-pushed
the
tickets/DM-42302
branch
from
5cff668
to
f597fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires lsst/daf_butler#929
Checklist
doc/changes