DM-42751: Add num_proc parameter to SeparablePipelineExecutor.run_pipeline() #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Feb 1, 2024
| @@ -241,6 +239,7 @@ def run_pipeline( | |||
| graph: lsst.pipe.base.QuantumGraph, | |||
| fail_fast: bool = False, | |||
| graph_executor: QuantumGraphExecutor | None = None, | |||
| num_proc: int = 1, | |||
There was a problem hiding this comment.
While I'm fine with changing the default to 1, I'm less fine about encoding that default in a parameter. The point of SeparablePipelineExecutor is to let the user plug in customized components as needed. I'm now wondering how fail_fast got in there; it doesn't seem to be something requested on #230.
Edit: making this very change was discussed on the old PR, but no mention of why I thought fail_fast was an exception.
kfindeisen
approved these changes
Feb 1, 2024
The default of 80% of available cores without any direct means to adjust it with `run_pipeline` was causing issues in notebooks where we spawn new subprocesses rather than forking. The default has now changed to 1 core with no spawning.
timj
force-pushed
the
tickets/DM-42751
branch
from
10836d1
to
5529847
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 87.41% 87.40% -0.01%
==========================================
Files 49 49
Lines 4433 4431 -2
Branches 764 764
==========================================
- Hits 3875 3873 -2
Misses 406 406
Partials 152 152 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes