Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43363: Remove extraneous files from pipetask report tests #285

Merged
merged 1 commit into from Mar 26, 2024

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Mar 22, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (94d7893) to head (e800908).

❗ Current head e800908 differs from pull request most recent head e77f2eb. Consider uploading reports for the commit e77f2eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   87.44%   87.35%   -0.09%     
==========================================
  Files          49       49              
  Lines        4467     4467              
  Branches      770      770              
==========================================
- Hits         3906     3902       -4     
- Misses        408      412       +4     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigerx eigerx requested a review from timj March 26, 2024 18:14
@timj
Copy link
Member

timj commented Mar 26, 2024

I think the coverage dropping might be that show_errors is now never True? In the future consider having a test that does write the error file and then have you read the error file in to make sure it has the content you want.

@eigerx
Copy link
Contributor Author

eigerx commented Mar 26, 2024

Thanks for the review @timj ! I made a ticket for next sprint to include Pydantic models to validate pipetask report output.

@eigerx eigerx merged commit d2bfc69 into main Mar 26, 2024
13 checks passed
@eigerx eigerx deleted the tickets/DM-43363 branch March 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants