Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40441: first batch of deprecations from RFC-949 #287

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    7274e9b View commit details
    Browse the repository at this point in the history
  2. Switch to new QG generation interfaces in CmdLineFwk.

    The same code was already being called in the end, but now we're
    bypassing the soon-to-be-deprecated backwards-compatibility shim.
    TallJimbo committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0473f1e View commit details
    Browse the repository at this point in the history
  3. Remove unused **kwargs from SimplePipelineExecutor.from_pipeline.

    These have apparently been there from the beginning, but seem to have
    never been used and never documented.
    TallJimbo committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5a50b19 View commit details
    Browse the repository at this point in the history
  4. Modernize SimplePipelineExecutor via PipelineGraph/QGB.

    This also deprecates iterable-of-TaskDef inputs to
    SimplePipelineExecutor.
    TallJimbo committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    20d0a87 View commit details
    Browse the repository at this point in the history
  5. Use new QG builders in SeparablePipelineExecutor.

    This deprecates the 'builder' argument to make_quantum_graph in favor
    of the new 'builder_class' argument.
    TallJimbo committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c3c0d63 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a299263 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fd6236c View commit details
    Browse the repository at this point in the history
  8. Rework tests to avoid changing registry after QG generation.

    Since the QG is now frequently responsible for carrying information
    about registry dataset types to executing code, we don't want it to be
    legal to change the registry definition after making a QG and then run
    that QG.  We also can't really stop it most of the time, but we can at
    least make these tests not do it.
    TallJimbo committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d51d1fc View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Use PipelineGraph in PreExecInit.

    ...instead of PipelineDatasetTypes.
    
    This includes a check on changes to registry dataset types between QG
    generation and execution, but only when executing with full butler.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c3d9f8c View commit details
    Browse the repository at this point in the history
  2. Support TaskNode and deprecate TaskDef in TaskFactory.

    Calling code in this package will be updated to avoid the new warning
    in a later commit.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d8a2085 View commit details
    Browse the repository at this point in the history
  3. Support TaskNode and deprecate TaskDef in LogCapture.

    Calling code in this package will be updated to avoid the new warning
    in a later commit.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a789093 View commit details
    Browse the repository at this point in the history
  4. Support TaskNode and deprecate TaskDef in executors.

    This should eliminate all new deprecation warnings from internal
    ctrl_mpexec calls.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    42318dd View commit details
    Browse the repository at this point in the history
  5. Replace util.filterTasks with util.filterTaskNodes.

    It's easier to deprecate the whole function than it is to migrate its
    return type.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ec74e39 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38f6a44 View commit details
    Browse the repository at this point in the history
  7. Silence deprecation warning in dotTools.

    I'm deferring actually removing this usage to DM-40639, since there's
    an opportunity to easily make a nice improvement to this code at the
    same time, but only after DM-39779 merges (and I don't want to increase
    the scope of this ticket further).
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    45a5595 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    10e92fd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6d58cc1 View commit details
    Browse the repository at this point in the history
  10. Bump deprecation->removal version from v26 to v27.

    Co-authored-by: Tim Jenness <tjenness@lsst.org>
    TallJimbo and timj committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3f35ac0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fab8c00 View commit details
    Browse the repository at this point in the history