DM-22364: Now must explicitly specify where a fake posix datastore exists #35
Conversation
tests/test_cmdLineFwk.py
Outdated
| """ | ||
| args = argparse.Namespace() | ||
| args.butler_config = None | ||
| args.butler_config = Config() | ||
| args.butler_config.configFile = "." # Lie about where the datastore is located |
There was a problem hiding this comment.
I'm against lying in general. Could you rephrase it to something like "configFile must be specified but it does not matter in this case"? Could you specify configFile in a constructor? If empty Config constructor is not useful for cases like this maybe it should be disabled entirely?
There was a problem hiding this comment.
In this particular case you only want access to registry and don't care where datastore is located. An empty Config to construct a Butler in theory could be fine since defaults are picked up, but in the specific case the default is to use a relocatable datastore configuration so you then have a bit of a chicken and egg problem. I don't think it's the fault of Config that it's not usable to construct a Butler if it's empty.
Now that Butler gets upset if a relocatable config is supplied without a specific location, we need to say in the test where we are going to write the datastore, even though no datastore is being used.
timj
force-pushed
the
tickets/DM-22364
branch
from
6802fdf
to
2aff142
Compare
No description provided.