DM-22504: Support for lsstDebug functionality in Gen3 middleware #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Dec 13, 2019
| try: | ||
| _LOG.debug("Will try to import debug.py") | ||
| import debug | ||
| assert debug # silence pyflakes |
There was a problem hiding this comment.
I think you mean "silence flake8", as that's the linter we use in CI, and I think we'd usually use a # noqa:<something> comment on the prevoius line.
There was a problem hiding this comment.
Indeed, it's a copy&paste from CmdLineTask and I did not give any thought to it. Will fix it with noqa:F401.
The --debug option existed but did not do anyhting, added code that imports `debug.py` when that option is set. Compared to CmdLineTask in `pipetask` I do it in two places, once before PreExecInit (in case someone needs to debug task construction) and once before running each task. Latter is not needed if `multiprocess` uses 'fork' start method but it is impossible to guarantee that is always true on all platforms.
andy-slac
force-pushed
the
tickets/DM-22504
branch
from
bc0f789
to
fb2097b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --debug option existed but did not do anyhting, added code that
imports
debug.pywhen that option is set. Compared to CmdLineTask inpipetaskI do it in two places, once before PreExecInit (in casesomeone needs to debug task construction) and once before running each
task. Latter is not needed if
multiprocessuses 'fork' start methodbut it is impossible to guarantee that is always true on all platforms.